feat: add :createMultichainAccountGroups action to batch account creation #7801
Open
feat: add :createMultichainAccountGroups action to batch account creation #7801
:createMultichainAccountGroups action to batch account creation #7801Conversation
hmalik88
reviewed
Feb 2, 2026
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
ccharly
force-pushed
the
cc/feat/snap-keyring-createAccounts
branch
from
a52de96 to
ec380f9
Compare
ccharly
force-pushed
the
cc/feat/snap-keyring-createAccounts
branch
from
ec380f9 to
9abe68a
Compare
ccharly
force-pushed
the
cc/feat/snap-keyring-createAccounts
branch
from
82c92fa to
cb0e654
Compare
This reverts commit cb0e654.
5 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountService.test.ts
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding batch account creation support to the
AccountProvider(emulated for now for Snap account providers).Also added
:createMultichainAccountGroupsaction to be able to create multiple group at once.References
N/A
Checklist
Note
Medium Risk
Touches core account/group creation paths and introduces new range-based/batched provider behavior (including background non-EVM creation), so regressions could impact wallet initialization or account alignment despite expanded test coverage.
Overview
Adds a new messenger action/method,
MultichainAccountService:createMultichainAccountGroups, to batch-create multichain account groups over a group-index range.Refactors
MultichainAccountWalletgroup creation to use range-based account creation: EVM accounts are created in a single range call and groups are created/updated from that state, while non-EVM providers either run in the background (default) with warning aggregation or are fully awaited with hard-failure whenwaitForAllProvidersToFinishCreatingAccountsistrue.Extends
EvmAccountProvider,SolAccountProvider,BtcAccountProvider, andTrxAccountProviderto supportAccountCreationType.Bip44DeriveIndexRange(EVM optimized with singlewithKeyring+addAccounts+ batchedAccountsController:getAccounts), adds shared range/index validation and error-message helpers inutils.ts, and updates tests/changelog accordingly.Written by Cursor Bugbot for commit a24ea0f. This will update automatically on new commits. Configure here.